ngx-pinch-zoom icon indicating copy to clipboard operation
ngx-pinch-zoom copied to clipboard

Angular 12

Open ramoncarreras opened this issue 3 years ago • 14 comments

Would it be possible to bump angular to version 12?

ramoncarreras avatar May 24 '21 11:05 ramoncarreras

@drozhzhin-n-e is this repository still active and will be updated to Angular 12?

AE1NS avatar Jun 17 '21 05:06 AE1NS

interesting to have this update as well please

marshall86 avatar Sep 02 '21 10:09 marshall86

I'm interested in this update too.

z-index-developer avatar Sep 02 '21 18:09 z-index-developer

I would also really need this update

cool-itkfm avatar Oct 12 '21 13:10 cool-itkfm

It works fine here on ng12 and 13. What exactly is the problem?

muuvmuuv avatar Nov 04 '21 13:11 muuvmuuv

if there is no issue, we just need the package.json to be updated to the latest angular version pls

marshall86 avatar Nov 04 '21 15:11 marshall86

i managed to install it with --force on angular 12 and works fine

mejriyassine avatar Dec 09 '21 22:12 mejriyassine

When using with Angular 13, npm gives the following warnings:-

npm WARN [email protected] requires a peer of @angular/common@^11.1.2 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of @angular/core@^11.1.2 but none is installed. You must install peer dependencies yourself.

chrisvelevitch avatar Mar 14 '22 05:03 chrisvelevitch

When using with Angular 13, npm gives the following warnings:-

npm WARN [email protected] requires a peer of @angular/common@^11.1.2 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of @angular/core@^11.1.2 but none is installed. You must install peer dependencies yourself.

https://github.com/across-the-stars/ngx-pinch-zoom/commit/b888a61ff1be0c0855b644c8283bebf51940ec6f Someone updated to Angular 12. https://github.com/across-the-stars/ngx-pinch-zoom

danielehrhardt avatar Apr 04 '22 12:04 danielehrhardt

Seems now with latest Angular I cannot get rid of "Uncaught Error: Type PinchZoomModule does not have 'ɵmod' property." TSCC does not run/compile it properly.

muuvmuuv avatar Apr 11 '22 08:04 muuvmuuv

Seems now with latest Angular I cannot get rid of "Uncaught Error: Type PinchZoomModule does not have 'ɵmod' property." TSCC does not run/compile it properly.

same.

danielehrhardt avatar Apr 11 '22 08:04 danielehrhardt

Seems now with latest Angular I cannot get rid of "Uncaught Error: Type PinchZoomModule does not have 'ɵmod' property." TSCC does not run/compile it properly.

Same

aceleghin avatar Apr 22 '22 09:04 aceleghin

Seems now with latest Angular I cannot get rid of "Uncaught Error: Type PinchZoomModule does not have 'ɵmod' property." TSCC does not run/compile it properly.

how did you solve this?

HusFNS avatar Jun 03 '22 09:06 HusFNS

Deinstall and use instructions to STRG+/- 😅 ... we are using a JS Vanilla lib instead

muuvmuuv avatar Jun 03 '22 11:06 muuvmuuv