drowe67
drowe67
@lukasostendorf - thanks, I'm currently traveling but will review this and the proposed fix in a few weeks. @tmiw - do you have any comments?
Thanks @tmiw. If you think you have a quick fix and don't mind working on it pls feel free to go ahead and raise a PR.
@tmiw - did any of the issues detected by AddressSanitizer cause any actual, real world issues, when running say freedv-gui? The changes in https://github.com/drowe67/codec2/pull/45 are minor tweaks mainly in test...
@tmiw - I'm not convinced this is an issue we should be addressing at this time. We made a decision at PLT that non-critical bugs - especially in deprecated modes...
@DJ2LS :point_up: This is branched off #44 so you can try both together.
@DJ2LS - I've had a go at a non-table driven interleaver algorithm in C and Octave. I haven't tested it on the on (16200,9720) code yet as I don't have...
> but it seems we have to adjust `allocate_tx_bpf` and `allocate_rx_bpf` functions in https://github.com/drowe67/codec2/blob/dr-freedata-001/src/ofdm.c ,` the 'CUSTOM' mode seems to be missing, I guess. Yes we'll have to figure out...
> The ` set_data_bits_per_frame` function for adjusting the used data bits for a ldpc code might be of interest 🤔 Is there a chance, we can implement it? So run...
> At least the intention is, modifying the amount of data bits of a code, like done with datac14 for example. It seems, this is important for mode designing when...
@DJ2LS - I've worked out a way to set the number of used data bits per LDPC codeword auto-magically.