Dominik Röttsches

Results 112 comments of Dominik Röttsches

Also, contrary to what I said earlier: ![image](https://user-images.githubusercontent.com/1021784/163212432-07f588bd-4e13-4d04-8abb-8c0ccdf69e24.png) > This shows: > Start color red is not drawn only from start angle, but from 0 degrees, but color stop 0...

With [WIP Skia CL #532057](https://skia-review.googlesource.com/c/skia/+/532057) we are getting closer but we still need some clarifications on what happens at the 0 / 360 degree boundary. #### Extend mode pad: Test...

New, wider set of tests in https://github.com/googlefonts/color-fonts/pull/119, Chrome rendering with https://skia-review.googlesource.com/c/skia/+/566416 ![image](https://user-images.githubusercontent.com/1021784/184634045-fc36cf8f-2269-44a8-bb0e-b857e1389518.png)

@annevk, I see from the minutes action items: > ACTION drott to investigate for Chrome > ACTION emilio to investigate for Firefox But I have trouble extracting exactly what were...

For me, `pip install aubio` worked without the `if (avFormatCtx->streams[i]->codec->codec_type == AVMEDIA_TYPE_AUDIO) {` compilation error message when I first installed aubio using homebrew: `brew install aubio`, then `pip install aubio`...

Thanks for doing that. Non owner LGTM, but I am wondering if when option `colr-cycle-check` is set to false the whole traversal could be skipped?

In my mind, it depends on performance and threat model considerations: From Chrome's perspective, I see the value in OTS in preventing downloading malicious fonts that would be passed to...

I can contribute my biased opinion :) LGTM, this is how we're doing it in the FreeType backend in Skia ([1](https://source.chromium.org/chromium/chromium/src/+/main:third_party/skia/src/ports/SkFontHost_FreeType_common.cpp;drc=e9b97bb3b0d5209b7c82c3b405e4d452cc877592;l=1266), [2](https://source.chromium.org/chromium/chromium/src/+/main:third_party/skia/src/ports/SkFontHost_FreeType_common.cpp;l=1322?q=fonthost%20freetype%20composite) the `SkAutoCanvasRestore` does two pops), and how I...

> @drott where's your live test page? I can test all against this branch to make sure. https://roettsch.es/var_colrv1.html

Or test definitions here: https://source.chromium.org/chromium/chromium/src/+/main:third_party/skia/gm/colrv1.cpp;l=187?q=gm%2Fcolrv1.cpp