godropbox

godropbox copied to clipboard

fix forgotten return in case of invalid line format from memcache ascii client

1

I ran [govanish](https://github.com/sivukhin/govanish) linter (it still in the WIP phase) against `godropbox` repo and it found one suspicious place: ``` 2023/12/24 17:03:42 it seems like your code vanished from compiled...

sivukhin

database/binlog: fix dropped error

1

This fixes a dropped `err` variable in `database/binlog`. Additionally, `gofmt` reformatted some comments automatically. I can remove this change if it is unwelcome.

alrs

Benchmark results: ``` Fake dealer: BenchmarkGetConnection-16 1492227 803.2 ns/op BenchmarkGetConnectionMaxIdle-16 1888982 631.4 ns/op Real dealer: BenchmarkGetConnection-16 9052 113356 ns/op BenchmarkGetConnectionMaxIdle-16 1901071 626.9 ns/op ``` Code example: ``` func BenchmarkGetConnection(b *testing.B)...

gugu

Does the mysql binlog package work for mysql 8 despite the readme saying max v5.6?

pjebs

memcached binary client imposes restrictions on key

1

I noticed that the Memcached binary protocol client provided by this library performs checks on the keys and disallows certain byte values, perhaps to maintain compatibility with the ASCII protocol:...

ji-han

Curious is the memcache package compatible with AWS and does it support AWS Auto Discovery? https://docs.aws.amazon.com/AmazonElastiCache/latest/mem-ug/AutoDiscovery.HowAutoDiscoveryWorks.html

marcsantiago