dropshots icon indicating copy to clipboard operation
dropshots copied to clipboard

Incorrect location of screenshots for tests in flavored sources

Open saket opened this issue 2 years ago • 4 comments

Dropshots stores screenshots in my androidTest directory even when my tests are present in androidTestDebug. Is this intentional?

saket avatar Jan 20 '23 08:01 saket

Hi Saket, Interesting question, do you specify a specific path for your debug tests? this is where the folder of the screenshots is defined: https://github.com/dropbox/dropshots/blob/main/dropshots-gradle-plugin/src/main/kotlin/com/dropbox/dropshots/DropshotsPlugin.kt#L47 Currently the folder doesn't seem to take into account the flavor and that is a problem if you are expecting different outputs from different flavors

sebastienrouif avatar Mar 16 '23 09:03 sebastienrouif

do you specify a specific path for your debug tests?

do you mean in my build script?

saket avatar Mar 16 '23 15:03 saket

@rharter what was the reasoning to have the screenshots in the "screenshot" folder and not an asset folder inside a res/assets folder ?

sebastienrouif avatar Apr 04 '24 23:04 sebastienrouif

It's integrated into assets at built time, but it's also used as task input and output, so plays into Gradles up-to-date checks.

rharter avatar Apr 05 '24 00:04 rharter