dropbox-sdk-js icon indicating copy to clipboard operation
dropbox-sdk-js copied to clipboard

popup oauth?

Open bcoover opened this issue 8 years ago • 10 comments

Where has the popup oauth method gone? Will you bring it back? How would one go about implementing this?

bcoover avatar Sep 15 '16 02:09 bcoover

It sounds like you're referring to the Dropbox.AuthDriver.Popup functionality in the old dropbox-js library. This dropbox-sdk-js library is entirely new, and doesn't share code with that one. I'll send this along as a feature request for a pop-up authorization flow in this SDK like the old one had.

(You can see how that's implemented in the code for Dropbox.AuthDriver.Popup if you want to reproduce it though.)

greg-db avatar Sep 15 '16 16:09 greg-db

Is there any chance we will see this implemented? I find it rather hard to integrate our single page app without this feature.

The chooser/saver dialogs would be perfect from a usability perspective: they provide a save/load dialog inside a popup coupled with an authentication - however afaik they lack the ability to save a javascript data-blob - so a plain client-side solution is not possible.

The old SDK did a good job hiding this URL manipulation/extraction procedure from the dev.

martin-y avatar Apr 24 '17 14:04 martin-y

Thanks for the feedback @martin-y . Unfortunately, no, I'm not aware of any immediate plans to implement this.

greg-db avatar Apr 24 '17 17:04 greg-db

@greg-db why can't we just have a getAcessToken() function that returns a promise which opens up a popup window and returns the access token once the promise resolves? I think the currently implemented way of returning the access token in the URL is one of the worst ways an API could treat developers 😒

yassbaat avatar Dec 27 '17 13:12 yassbaat

@yassbaat Thanks for the feedback! I'll add this to the feature request.

greg-db avatar Dec 27 '17 15:12 greg-db

@greg-db Any news on that feature request?

ivocass avatar Jan 03 '19 13:01 ivocass

@ivocass No, I'm afraid I don't have any news on this.

greg-db avatar Jan 03 '19 15:01 greg-db

hey guys any updated yet on implementing chooser in sdk ?just like we do in dropins.js

BabuBahir avatar Jul 23 '20 06:07 BabuBahir

@BabuBahir No, unfortunately I don't have an update on this request.

greg-db avatar Jul 23 '20 14:07 greg-db

Not an official solution but this might support your needs: https://github.com/rogebrd/dropbox-oauth-popup

rogebrd avatar Oct 15 '20 16:10 rogebrd