dropbox-sdk-js icon indicating copy to clipboard operation
dropbox-sdk-js copied to clipboard

Published 20 hours ago • verified publisher icon dropbox

Wrong Typings for refresh access token methods

Open FloppyNotFound opened this issue 3 years ago • 5 comments

Describe the bug The index.d.ts file shows wrong type information for the two following methods:

  • checkAndRefreshAccessToken
  • refreshAccessToken

To Reproduce Compare the types of https://github.com/dropbox/dropbox-sdk-js/blob/main/types/index.d.ts

with the actual return types: https://github.com/dropbox/dropbox-sdk-js/blob/main/src/auth.js

Expected Behavior The typings file index.d.ts should declare the return type of the two mentioned methods to be a Promise.

Actual Behavior The typings file index.d.ts claims that the return type of the two mentioned methods is void.

Screenshots image

Versions

  • What version of the SDK are you using? 9.4.0
  • What version of the language are you using? Typescript 4.1.0
  • Are you using Javascript or Typescript? Typescript

FloppyNotFound avatar Apr 02 '21 12:04 FloppyNotFound

Thanks! I'll ask the team to fix that up.

greg-db avatar Apr 02 '21 15:04 greg-db

Still waiting for this. Any update?

abeebola avatar Sep 07 '21 10:09 abeebola

No, I don't have an update on this from the team yet. I'll be sure to follow up here once I do.

greg-db avatar Sep 07 '21 15:09 greg-db

any updates? its been years

sakgoyal avatar Oct 20 '23 23:10 sakgoyal

No, unfortunately I don't have news on this issue.

greg-db avatar Oct 23 '23 13:10 greg-db