dropbox-sdk-js icon indicating copy to clipboard operation
dropbox-sdk-js copied to clipboard

Duplicate Contents property in UploadSessionAppendArg And UploadSessionFinishArg

Open GrayDelacluyse opened this issue 6 years ago • 3 comments

https://github.com/dropbox/dropbox-sdk-js/blob/86a8856b84702dfd0821efd3a99334bed0e986b3/generator/typescript/dropbox_types.d.ts#L3304

Why is the contents required twice on UploadSessionAppendArg and UploadSessionFinishArg?

Both Types have a cursor (UploadSessionCursor) which requires the contents property as well as the parent object.

My assumption is that this would result in the data being duplicated in transit, for every call.

Thanks!

GrayDelacluyse avatar May 03 '18 21:05 GrayDelacluyse

Thanks for the report! It looks like UploadSessionCursor object does indeed have a contents properties when it shouldn't. I'll ask the team to get that cleaned up.

greg-db avatar May 04 '18 18:05 greg-db

Any update on this? The library is not useable as is.

bluecamel avatar Sep 06 '18 21:09 bluecamel

No, I don't have an update on this yet.

greg-db avatar Sep 07 '18 12:09 greg-db