dropbox-sdk-dotnet icon indicating copy to clipboard operation
dropbox-sdk-dotnet copied to clipboard

DropboxOAuth2Helper.ProcessCodeFlowAsync()'s state parameter is lost/ignored

Open MarkMichaelis opened this issue 3 years ago • 1 comments

Describe the bug When invoking DropboxOAuth2Helper.ProcessCodeFlowAsync(Uri responseUri, string appKey, string appSecret, string redirectUri = null, string state = null, HttpClient client = null, string codeVerifier = null), the one with the state parameter, the state parameter is ignored/abandoned.

To Reproduce Invoke the DropboxOAuth2Helper.ProcessCodeFlowAsync() (the one that includes a state parameter), and then check the State property on the response. The states should be the same value as passed in but, instead, the value is null.

Expected Behavior When calling ProcessCodeFlowAsync() with a state parameter the returned OAuth2Response should include the state.

Actual Behavior When calling ProcessCodeFlowAsync() with a state parameter the returned OAuth2Response's State property is null

Screenshots If applicable, add screenshots to help explain your problem.

Versions

  • What version of the SDK are you using? v6.8 but I assume the problem has been around for some time.

Additional context Notice that the OAuthPKCE sample does not test the state whereas the SimpleTest sample does.

MarkMichaelis avatar Jun 20 '21 16:06 MarkMichaelis

Thanks! We'll look into it.

greg-db avatar Jun 21 '21 16:06 greg-db