dropbox-api-content-hasher icon indicating copy to clipboard operation
dropbox-api-content-hasher copied to clipboard

Modernize dropbox_content_hasher

Open richo opened this issue 6 years ago • 9 comments

Hi!

I ported this to use more recent crates and features in rust. I had a quick look at the existing test suite, but they look pretty coupled to some deprecated features of the rand crate, so while I made some changes to check that they still compile I wasn't really able to reason about their correctness. Using this in my application though, it generates correct results.

Also, I realise this has been asked before, but can you push this to crates.io? Without putting too finer point on it, I can today push it since nothing is on the name. If nothing else it would be worthwhile for dropbox to camp it to avoid someone else doing the same.

chur

richo avatar Sep 05 '18 06:09 richo

Thanks for putting this together! I'll ask the team to review this, and to also look into getting this on crates.io.

greg-db avatar Sep 05 '18 14:09 greg-db

Hey @greg-db did anyone get a chance to have a look at this?

richo avatar Sep 13 '18 05:09 richo

@richo No, I'm afraid I don't have any update on this.

greg-db avatar Sep 13 '18 14:09 greg-db

Sorry to nag, but is there any movement here? I have a copy of this in tree of one of my side projects, but it's a little frustrating to have no canonical source.

richo avatar Jan 23 '19 08:01 richo

@richo No, unfortunately I don't have any progress to report on this.

greg-db avatar Jan 23 '19 15:01 greg-db

No worries. Thanks for letting me know.

It's been a bit impractical to not have a version available on cargo and to have it in my tree, so I've broken my fork out into https://github.com/richo/dropbox-content-hasher and pushed it to crates.io as dropbox-content-hasher. If Dropbox would like to have the repo or crate name, just let me know and I'd be happy to transfer either/both.

richo avatar Jan 27 '19 05:01 richo

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 16 '22 21:04 CLAassistant

Ok, I signed the CLA. Is there any chance of having this upstreamed?

richo avatar Apr 18 '22 16:04 richo

Thanks! I can't make any promises myself, but I'll raise this with the team again.

greg-db avatar Apr 18 '22 17:04 greg-db