PyHive icon indicating copy to clipboard operation
PyHive copied to clipboard

Added Sqlalchemy param bindings

Open mlorenzana opened this issue 7 years ago • 5 comments

Added conversions for Date, Timestamp and Decimal

mlorenzana avatar Jun 21 '17 20:06 mlorenzana

Codecov Report

Merging #133 into master will increase coverage by 0.6%. The diff coverage is 30.76%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #133     +/-   ##
=========================================
+ Coverage   89.49%   90.09%   +0.6%     
=========================================
  Files          15       15             
  Lines        1608     1565     -43     
  Branches      190      181      -9     
=========================================
- Hits         1439     1410     -29     
+ Misses        131      117     -14     
  Partials       38       38
Impacted Files Coverage Δ
pyhive/sqlalchemy_hive.py 90.19% <30.76%> (-0.91%) :arrow_down:
pyhive/tests/test_hive.py 96.59% <0%> (-0.74%) :arrow_down:
pyhive/presto.py 93.38% <0%> (-0.28%) :arrow_down:
pyhive/tests/sqlalchemy_test_case.py 100% <0%> (ø) :arrow_up:
pyhive/tests/test_presto.py 100% <0%> (ø) :arrow_up:
pyhive/hive.py 90.59% <0%> (+0.49%) :arrow_up:
pyhive/common.py 96.09% <0%> (+1.56%) :arrow_up:
pyhive/tests/test_sqlalchemy_hive.py 100% <0%> (+1.83%) :arrow_up:
pyhive/sqlalchemy_backports.py 48.55% <0%> (+2.89%) :arrow_up:
pyhive/sqlalchemy_presto.py 92.36% <0%> (+3.05%) :arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d787916...a7a6ac1. Read the comment docs.

codecov-io avatar Jun 21 '17 20:06 codecov-io

Any chance at a review? This adds functionality for using selectables with python datetime, date and decimal types.

mlorenzana avatar Jun 23 '17 13:06 mlorenzana

Sorry, haven't forgotten about this. Will take a look next week.

jingw avatar Jun 24 '17 00:06 jingw

gentle ping @mlorenzana @jingw

tooptoop4 avatar Jun 18 '19 10:06 tooptoop4

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Apr 16 '22 21:04 CLAassistant