go-scm icon indicating copy to clipboard operation
go-scm copied to clipboard
verified publisher icon drone

fix: pass gitlab mergerequest param via json body

Open olblak opened this issue 1 year ago • 1 comments

When opening a merge request on GitLab, the current implementation pass all the parameters via the URL parameters instead of using the HTTP body. The problem is that the amount of information that can be provided via URL parameter is very limited, which lead to not being able to create a merge request.

Test

On top of the unit test, I tested this change on a different project:

Screenshot

image

Additional Information

Potential improvement

I also noticed that function ⁣CreateComment use URL parameter and I think it could also be improved but I am not using that function on my project

olblak avatar Aug 29 '24 12:08 olblak

@abhinav-harness could you take a look at this pull request, as it fix a bug with the GitLab merge request creation

olblak avatar Oct 07 '24 07:10 olblak

@abhinav-harness Would it be possible to have this pullrequest available in a futur release?

olblak avatar Nov 21 '24 17:11 olblak

@olblak released https://github.com/drone/go-scm/releases/tag/v1.39.0

abhinav-harness avatar Nov 21 '24 18:11 abhinav-harness