fix: escaping to git ref in path not working

[chamhaw]

It seems an inadvertent mistake for escaping.

[bradrydzewski]

Great catch. I feel like there may be one more bug fix needed. Once we properly escape the reference it would prevent the subsequent scm.TrimRef call from working properly. I'm not sure if / how this would manifest into a bug, but it would be great to do some more research on this and maybe get some unit tests for the different scenarios. cc @d1wilko @tphoney

[chamhaw]

Can this bug be fixed? @bradrydzewski @d1wilko @tboerger

[bradrydzewski]

@chamhaw this needs to be addressed before we can get this merged

Once we properly escape the reference it would prevent the subsequent scm.TrimRef call from working properly

I think it is a simple order of operations issue. trim before you encode and that probably resolves the comment.