drone-yaml icon indicating copy to clipboard operation
drone-yaml copied to clipboard

Published 20 hours ago • verified publisher icon drone

Add IpcMode

Open stevecrozz opened this issue 6 years ago • 3 comments

Together with a PR in drone-runtime, this adds support for using ipc as documented in docker-compose: https://docs.docker.com/compose/compose-file/#domainname-hostname-ipc-mac_address-privileged-read_only-shm_size-stdin_open-tty-user-working_dir

I will be testing to ensure the containers work as expected tomorrow, but I'm putting these PRs now in case the maintainers have any feedback for me before I get too deep.

stevecrozz avatar Jun 14 '19 04:06 stevecrozz

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 14 '19 04:06 CLAassistant

Build is failing because it requires https://github.com/drone/drone-runtime/pull/75

stevecrozz avatar Jun 14 '19 04:06 stevecrozz

As a followup, I ran tests this morning and verified steps that use ipc: host actually result in containers with IpcMode: "host". So this is working the way I expect.

stevecrozz avatar Jun 14 '19 16:06 stevecrozz