drone
Add Pulls and Pushes view to individual repo
This PR adds a filtering of the Activity feed by pull requests and pushes to each individual repo view.
Some questions I wanted to clarify -
- There were existing lint errors, I cleaned up a few that I saw but there are still some, should I clean all of them up?
- The readme calls out running tests, but I could not find any. Am I missing them?
Example:
Hey @NicsWorld we should touch base in Gitter to discuss.
We have some code in the vue-1.0.0 branch for dedicated branch and deployment screens. You can see a screenshot here:
The above interaction is more comparable to the GitHub branches and pull request pages, showing the latest status for each:
This is something we discussed quite a bit when this interaction was designed. We felt that showing the latest build per branch is the optimal user interaction most of the time, however, there will definitely be times when you want to drill down to see a list of recently builds for a specific branch. It would be great to augment this interaction with a drill-down. Travis has an interesting grid view although I would concerned with database performance when rending this page.
Also, we now have dedicated endpoints for fetching builds by branch 🎉. These endpoints are helpful because you are otherwise sourcing this data from the list of builds in the Vue store, which is going to be limited to the last 25 builds.
@bradrydzewski would now be a good time to maybe cleanup some of the old branches so this is less confusing in the future?
@bradrydzewski I think we can probably migrate to master now right? @jones2026 I believe the reason for separate branches is that 0.8 used go get to pull the UI from master and for a period of time we were maintaining 0.8 even after 1.x was launched. Now that 0.8 is formally end of life I think it is safe to move the 1.x code to master. Do you agree Brad? If so I can make the change.
Yes agreed, I went ahead and moved the vue branch to master. I will spend some time today trying to split the changes in vue-1.0.0 into separate feature branches so they can be worked on independently going forward.
We moved some of the code from vue-1.1.0 into master including the branch view (pictured below). You can see the interaction live here.
Instead of having separate tabs to show all builds by branch, pull request, etc I was thinking we could provide an option to filter the main activity screen. Ideally the interaction would be really simple, for example:
When clicking the filter button it could provide options to filter by common events and recent branches. The benefit of this sort of approach is simplicity. The event and branch fields in the database are indexed, so we would limit the filter to these fields.
Hey @bradrydzewski thanks for all the info! II will shoot you a message on gitter shortly. I actually spiked out a filter menu similar to what you showed, i'd love to pursue or help anyway I can!
Also see https://github.com/drone/drone-ui/pull/317 which filters by branch. This could be expanded to filter by event type.