drone-ui
drone-ui copied to clipboard
Integrates text-security npm module to Secrets component
Hides the sensitive secret information while typing as password disc symbols to prevent shoulder surfing.
@bradrydzewski @tboerger There were some compilation errors when I tried to include svg, eot and ttf font files. It seems they require updated version of file-loader and url-loader modules. ( Ref: https://github.com/webpack/webpack/issues/6419 ). The latest version of both the modules are added to package.json
Closes #302
cc: @HrushikeshK
@tboerger I wasn't familiar with VUE, so I faced issues in importing node_modules. After digging up a bit, I found a new way and its working like a charm. Just removing the "~" did the job perfectly. Please check it.
@bradrydzewski @tboerger any changes required for the code? any updates?
I would name the class
hide-secret
, but besides that LGTM
Done. I was more associated with JS, so just got used to JS coding conventions.
cool :+1:
The change looks great, is anyone merging this soon?