drone-ui icon indicating copy to clipboard operation
drone-ui copied to clipboard

Integrates text-security npm module to Secrets component

Open rewanthtammana opened this issue 5 years ago • 5 comments

Hides the sensitive secret information while typing as password disc symbols to prevent shoulder surfing.

@bradrydzewski @tboerger There were some compilation errors when I tried to include svg, eot and ttf font files. It seems they require updated version of file-loader and url-loader modules. ( Ref: https://github.com/webpack/webpack/issues/6419 ). The latest version of both the modules are added to package.json

Closes #302

cc: @HrushikeshK

rewanthtammana avatar Jul 28 '19 10:07 rewanthtammana

@tboerger I wasn't familiar with VUE, so I faced issues in importing node_modules. After digging up a bit, I found a new way and its working like a charm. Just removing the "~" did the job perfectly. Please check it.

rewanthtammana avatar Aug 02 '19 11:08 rewanthtammana

@bradrydzewski @tboerger any changes required for the code? any updates?

rewanthtammana avatar Aug 06 '19 10:08 rewanthtammana

I would name the class hide-secret, but besides that LGTM

Done. I was more associated with JS, so just got used to JS coding conventions.

rewanthtammana avatar Aug 06 '19 10:08 rewanthtammana

cool :+1:

tboerger avatar Aug 06 '19 11:08 tboerger

The change looks great, is anyone merging this soon?

till avatar Dec 21 '19 20:12 till