drone-git icon indicating copy to clipboard operation
drone-git copied to clipboard

Set PATH in Dockerfile Instead of Clone Script

Open julmb opened this issue 2 years ago • 2 comments

This is based on PR #41.

In windows/clone.ps1 there is a comment

HACK: no clue how to set the PATH inside the Dockerfile, so am setting it here instead. This is not idea.

These changes set the PATH in the Dockerfile instead of in the windows/clone.ps1 script.

This has the added benefit of enabling the use of the drone/git image to use Git in a pipeline step on Windows (where there are no simple images like alpine/git).

- name: dependencies
  image: drone/git
  shell: pwsh
  commands:
  - git clone http://example.com/library.git

julmb avatar Oct 15 '21 13:10 julmb

@julmb Thank you very much for this. But, but we can't merge this PR now because currently we don't have a Windows 2022 machine...

marko-gacesa avatar Nov 02 '21 12:11 marko-gacesa

@julmb Thank you very much for this. But, but we can't merge this PR now because currently we don't have a Windows 2022 machine...

Judging from recent commits, there is now a Server 2022 machine in your CI system. Any chance of getting this merged?

julmb avatar Feb 07 '23 10:02 julmb