charts icon indicating copy to clipboard operation
charts copied to clipboard

Breaking environment

Open loeffel-io opened this issue 1 year ago • 8 comments

Upgrading to 0.5.0 (commit f058f765ba5aa09d1f6eb683230932c208a1042a) is breaking our whole system with drone chart 0.4.0 and droner-runner-kube chart 0.1.9

the drone-runner-kube can't ping the remote server anymore

loeffel-io avatar Jul 20 '22 08:07 loeffel-io

Hi @loeffel-io ,

Can you try updating your drone values.yaml to be have service like

service:
  type: ClusterIP
  port: 80

or you can update drone-runner-kube chart values to be like

DRONE_RPC_HOST: "drone:8080"

NOTE: Having to expose port 80 in many cases require extra privileges hence it was changed from 80 to 8080.

Let me know if this helps.

kameshsampath avatar Jul 20 '22 08:07 kameshsampath

Thanks for the answer - i will try that soon!

This breaking change should need more communication imo

loeffel-io avatar Jul 20 '22 09:07 loeffel-io

@loeffel-io apologies for the impact this has caused you. Were you on 0.4.0 of the drone chart previously? Is that version still working ok for you? There was an issue where the 0.4.0 chart might have had this same problem briefly, I just want to verify that 0.4.0 does not have this problem.

I agree that this change should have more communication. We need to create a proper changelog along with releases where we can better highlight breaking changes like this.

jimsheldon avatar Jul 20 '22 10:07 jimsheldon

I'm facing the same issue after updating chart from 0.4.0 to 0.5.0. From runner pod I can see the following error :

cannot ping the remote server" error="Post \"http://drone/rpc/v2/ping\": dial tcp 10.21.30.202:80: i/o timeout

I tried your workarounds @kameshsampath and both work.

keliansb avatar Jul 28 '22 14:07 keliansb

@loeffel-io apologies for the impact this has caused you. Were you on 0.4.0 of the drone chart previously? Is that version still working ok for you? There was an issue where the 0.4.0 chart might have had this same problem briefly, I just want to verify that 0.4.0 does not have this problem.

I agree that this change should have more communication. We need to create a proper changelog along with releases where we can better highlight breaking changes like this.

i think it was 0.2.5 to 0.4.0/0.5.0

loeffel-io avatar Aug 01 '22 07:08 loeffel-io

Sorry for the inconvenience it was mainly the default port that we changed in the release from default 80 to 8080 for helping users to run with lesser privileges.

@jimsheldon - shall we update the release notes to help users upgrade with this gotcha ?

kameshsampath avatar Aug 01 '22 07:08 kameshsampath

Just ran into this issue. Changing this env var for the runner resolved:

DRONE_RPC_HOST: "drone:8080"

Definitely think the defaults for the charts should match up.

AdamFerguson avatar Aug 10 '22 19:08 AdamFerguson

We should align this with #37

jimsheldon avatar Oct 21 '22 17:10 jimsheldon