drone-webhook icon indicating copy to clipboard operation
drone-webhook copied to clipboard

use “=” in the headers value

Open zzl221000 opened this issue 3 years ago • 8 comments

Using base64 encoded data in the header, webhook does not work. Because the following code:

                for _, value := range p.Config.Headers {
			header := strings.Split(value, "=")
			req.Header.Set(header[0], header[1])
		}

Maybe it could be changed to strings.SplitN(value, "=", 2)

zzl221000 avatar Dec 09 '21 11:12 zzl221000

I have to use the Cookies header, and the = cannot be parsed too. For example:

Cookie: key1=value1; key2=value2

I tried to make it run, but i cannot find any solution.

DongyunLee avatar Apr 08 '22 15:04 DongyunLee

you can try zzl221000/webhook image @DongyunLee

zzl221000 avatar Apr 08 '22 15:04 zzl221000

you can try zzl221000/webhook image @DongyunLee

好嘞,多谢

DongyunLee avatar Apr 08 '22 15:04 DongyunLee

you can try zzl221000/webhook image @DongyunLee

If settings are same as drone-webhook?

DongyunLee avatar Apr 08 '22 15:04 DongyunLee

If settings are same as drone-webhook?

It's a fork. I just fixed "=" bug. This repository seems to be out of maintenance

zzl221000 avatar Apr 08 '22 15:04 zzl221000

If settings are same as drone-webhook?

It's a fork. I just fixed "=" bug. This repository seems to be out of maintenance

多谢,现在能正常发出请求了

DongyunLee avatar Apr 08 '22 15:04 DongyunLee

@DongyunLee drone k8s 中构建镜像用 drone-kaniko比较方便

zzl221000 avatar Apr 08 '22 15:04 zzl221000

@DongyunLee drone k8s 中构建镜像用 drone-kaniko比较方便

收到,我学习一下

DongyunLee avatar Apr 08 '22 15:04 DongyunLee