drone-s3-sync icon indicating copy to clipboard operation
drone-s3-sync copied to clipboard

Documentation is confusing for the bucket parameter

Open mprasil opened this issue 7 years ago • 5 comments

The documentation shows bucket parameter provided in two different formats (actually twice for each example):

bucket: my-bucket-name
...
bucket: my-bucket.s3-website-us-east-1.amazonaws.com

Which format is the correct one?

The link to the documentation: http://plugins.drone.io/drone-plugins/drone-s3-sync/

mprasil avatar Sep 02 '17 21:09 mprasil

Which docs are you looking at?

bradrydzewski avatar Sep 02 '17 21:09 bradrydzewski

On my phone so can't test, but maybe consider testing both and then send a patch to the docs for whichever is the correct config

bradrydzewski avatar Sep 02 '17 21:09 bradrydzewski

This is a mistake from my side, I have not checked it but I think both formats should work, more common is the first one

tboerger avatar Sep 02 '17 21:09 tboerger

I think the first one works, (at least for couple of my configurations it does) though I have some failing one at the moment as well and not sure why is it failing yet.

mprasil avatar Sep 02 '17 21:09 mprasil

After looking through the source code, I think the second bucket entry in the documentation should actually be called endpoint.

FERNman avatar Sep 17 '20 14:09 FERNman