drone-docker icon indicating copy to clipboard operation
drone-docker copied to clipboard

20.18.6 does not build all stages anymore

Open gzm0 opened this issue 11 months ago • 3 comments

The trigger is almost certainly https://github.com/drone-plugins/drone-docker/pull/465 which upgraded Docker 20.10.14 -> 27.3.1. This switched to buildkit by default, which in turn changes the stage execution behavior.

This can be devastating to pipelines running tests in a separate stage:

FROM node:23.6.0@sha256:<something> AS base
FROM base AS build

COPY package.json .
COPY src .
RUN npm install
RUN npm build

FROM build AS tests

# After the upgrade to 20.18.6, these two commands to not run anymore.
COPY tests .
RUN npm test

FROM base AS image

COPY --from=build dist .

CMD ["dist/index.js"]

gzm0 avatar Jan 13 '25 08:01 gzm0

Not sure I would have realized that bumping a patch version from 20.18.4 -> 20.18.6 would have jumped 7?! major versions of docker

jwetzell avatar Jan 14 '25 14:01 jwetzell

Not sure I would have realized that bumping a patch version from 20.18.4 -> 20.18.6 would have jumped 7?! major versions of docker

😂 looks like this yeah

loeffel-io avatar Feb 13 '25 13:02 loeffel-io

ref: #466

loeffel-io avatar Feb 13 '25 13:02 loeffel-io