drone-docker icon indicating copy to clipboard operation
drone-docker copied to clipboard

label-schema.org labels are deprecated

Open The-Loeki opened this issue 7 years ago • 3 comments

The label-schema.org labels are deprecated in favour of the Open Container Specification ones. The builtin label-schema.org labels are therefore deprecated as well; I can hack up a PR, but we'd need to specify the behaviour regarding PLUGIN_LABELS and PLUGIN_CUSTOM_LABELS and not collide with #204 / #192 (where this was already discussed as well)

Related

  • #134
  • #135
  • #180
  • #192
  • #204

Refs

  • https://github.com/drone-plugins/drone-docker/issues/192#issuecomment-420132809
  • https://github.com/label-schema/label-schema.org#label-schemaorg
  • https://github.com/opencontainers/image-spec/blob/master/annotations.md

The-Loeki avatar Nov 06 '18 14:11 The-Loeki

I'm not entirely sure if we just follow the new definition or if we just define some labels in the io.drone namespace similar to the build number mentioned in the above pull request.

tboerger avatar Nov 06 '18 14:11 tboerger

well that seems a lot like the DRONE_ vs CI_ variables :)

I like having standarized ones as much as possible for my 5c, but as you mention in your thread, I'm not really sure where they are used (and thus may break if we'd change the label-schema.org ones for org.opencontainers ones)

The-Loeki avatar Nov 06 '18 15:11 The-Loeki

IMO there should be an option to disable the entire automatic label handling.

xoxys avatar Dec 21 '20 00:12 xoxys