Passing binary arrays to setBody

Open fantasy-peak opened this issue 1 year ago • 1 comments

Aug 28 '24 02:08 fantasy-peak

https://github.com/drogonframework/drogon/issues/2139

Aug 28 '24 02:08 fantasy-peak

I have no right to request any changes at all, but the current state of this PR is not something I would support.

Having to allocate my memory to transfer is as good/bad as copying it, so nothing changes here at all IMHO. Sorry for the harsh feedback though :/

I understand that we provide a method to take over externally allocated memory and avoid constructing strings,If this MR does not meet your needs, you can initiate a new MR based on your requirements

Sep 09 '24 14:09 fantasy-peak