Modlishka icon indicating copy to clipboard operation
Modlishka copied to clipboard

Allow secure cookies

Open defektive opened this issue 3 years ago • 4 comments

When stripping the secure flag, it breaks cookies with SameSite=None. This PR will add an option for users to disable the default stripping of secure cookies.

It also contains a .gitignore and go fmt in a separate commits, to make it easier to see what i really changed.

defektive avatar Feb 16 '22 19:02 defektive

If you are serving over HTTPS this addresses #250

defektive avatar Feb 16 '22 19:02 defektive

why reformat all the files lol

ghost avatar Feb 19 '22 08:02 ghost

I just ran

go fmt ./...

So they'd match the go standard. I did do it as a separate commit to make the changes easier to see. Most IDEs will auto run go fmt on save. I can drop the commit and repush if desired. Just let me know

defektive avatar Feb 19 '22 16:02 defektive

I just wanted to quickly view the new changes you made. I guess I didn't read the part where you said it was a separate commit, could've just opened that commit up, my bad lol.

I wouldn't touch any external code unrelated to the PR, but I'm not the maintainer nor necessarily represent their views. It's just a light nitpick, don't feel like you must make changes to your PR

ghost avatar Feb 19 '22 16:02 ghost