Jeroen Versteeg

Results 79 comments of Jeroen Versteeg

@giorgiosironi @matheusd the change proposed in my PR (#289) works for me in a simple case. I haven't tested anything other than Firefox on Ubuntu using isolated sessions. Can somebody...

@matheusd @nkovacs could you please take a look at my PR #289 and review?

@julianseeger are you sure `$this->url()` prefixes `$browserUrl`? I haven't tested, but the code really looks like it will simply use the absolute URL: ``` php class PHPUnit_Extensions_Selenium2TestCase_SessionCommand_Url { public function...

@fabpot and @stof, do you think this can be added in 3.x? Or do you consider it backward breaking, since new nodes are added to the lexer's token stream and...

One of the code style issues is: ``` - $nested = $nested || Node::class !== \get_class($node); + $nested = $nested || Node::class !== $node::class; ``` However, the suggested change isn't...

Bonjour Fabian, > I'm wondering if it would be better to define a tag instead of using comments. A new tag has the big advantage of not needing any change...

Fair enough. I'm actually thrilled to see you take this quite seriously! Twig certainly deserves better support for types. ❤️ However, I'm skeptical a new tag will be adopted in...

Aside from the type declarations, I can imagine the community adding support for more meta-level features, for example to suppress code inspections (similar to `@phpstan-ignore-next-line`). To enable the community to...

> But just for letting you known as soon as any implemention is on the way, it will be implemented together with a migration inspection. Thanks for chiming in. This...

@stof and @fabpot, have you reconsidered your stance on this PR? To summarize my position: I'm in favor of a first-class `var` tag. Once the Symfony Support plugin (and PhpStorm)...