[BUG]: using placeholders for inserts in sqlite doesn't work for types that transform values

[gmaclennan]

What version of drizzle-orm are you using?

0.27.2

What version of drizzle-kit are you using?

0.19.12

Describe the Bug

If I try to use a placeholder to insert values for a custom type, the value inserted is incorrect.

The same custom type works fine when used in a (non-prepared) insert.

e.g. given this schema:

import { integer, sqliteTable, customType } from 'drizzle-orm/sqlite-core'

const textArray = customType({
    dataType() { return 'text' },
    fromDriver(value) { return JSON.parse(value) },
    toDriver(value) { return JSON.stringify(value) },
})

export const table = sqliteTable('table', {
  list: textArray('list')
})

The following returns { list: { name: 'list' } } instead of { list: [] }:

const stmt = db
  .insert(table)
  .values({ list: placeholder('list') })
  .prepare()

stmt.run({ list: [] })
console.log(db.select().from(table).get())

However a normal insert (without prepare and placeholders) works fine:

db.insert(table).values({ list: [] }).run()
console.log(db.select().from(table).get())
// works as expected
// { list: [] }

What I can see is happening is that when valued() is called, the toDriver() function of my customType is called with a Placeholder instance. JSON.stringify() is being called on the Placeholder instance, which returns { name: 'list' }, which is what is being written to the database.

Minimal reproduction code: https://github.com/gmaclennan/drizzle-placeholder-bug/blob/main/index.js

Expected behavior

I would expect placeholders to work with custom fields in sqlite

Environment & setup

Running on MacOS, M2, Node v16.20.0, using better-sqlite3 as the driver.

[gmaclennan]

This same issue also applies when using a type blob('name', { mode: 'json' | 'bigint' }), or type integer('name', { mode: 'timestamp'). The issue is the same as above - toDriver() is being called with a Placeholder instance, and trying to act on it (resulting in incorrect data or an error).

[filipsobol]

I encountered the same problem when trying to create a prepared statement for the timestamp_ms column.

// Schema
export const sessions = sqliteTable('sessions', {
  // Skipped
  expiresAt: integer('expiresAt', { mode: 'timestamp_ms' }).notNull(),
});

// Prepared statement
export const queryInsertSession = db
  .insert(sessions)
  .values({
    // Skipped
    expiresAt: placeholder('expiresAt'),
  })
  .returning()
  .prepare();

This results in the following error:

TypeError: value.getTime is not a function
    at SQLiteTimestamp.mapToDriverValue (<PATH>/src/sqlite-core/columns/integer.ts:151:19)

Direct query works fine:

const session = db
  .insert(sessions)
  .values({
    // Skipped
    expiresAt: new Date(Date.now() + MILLISECONDS_IN_A_YEAR)
  })
  .returning()
  .get();

[Angelelz]

I discussed this briefly with a member of the team, an easy workaround is to do the transformation yourself in the execute function:

const stmt = db
  .insert(table)
  .values({ list: placeholder('list') })
  .prepare()

stmt.run({ list: table.list.mapToDriverValue([]) })

[ntriledev]

This workaround does not work for me

[Acorn221]

Hey, the workaround has worked for me but it would be amazing if this the prepared statements just worked as expected so I could use them in my code without having to worry about transforming

[L-Mario564]

I discussed this briefly with a member of the team, an easy workaround is to do the transformation yourself in the execute function:

const stmt = db
  .insert(table)
  .values({ list: placeholder('list') })
  .prepare()

stmt.run({ list: table.list.mapToDriverValue([]) })

I've added documentation related labels to this issue as the workaround seems to be pretty important to add to the docs.

[AndriiSherman]

Hey everyone!

I've created this message to send in a batch to all opened issues we have, just because there are a lot of them and I want to update all of you with our current work, why issues are not responded to, and the amount of work that has been done by our team over ~8 months.

I saw a lot of issues with suggestions on how to fix something while we were not responding – so thanks everyone. Also, thanks to everyone patiently waiting for a response from us and continuing to use Drizzle!

We currently have 4 major branches with a lot of work done. Each branch was handled by different devs and teams to make sure we could make all the changes in parallel.

---

First branch is drizzle-kit rewrite

All of the work can be found on the alternation-engine branch. Here is a PR with the work done: https://github.com/drizzle-team/drizzle-orm/pull/4439

As you can see, it has 167k added lines of code and 67k removed, which means we've completely rewritten the drizzle-kit alternation engine, the way we handle diffs for each dialect, together with expanding our test suite from 600 tests to ~9k test units for all different types of actions you can do with kit. More importantly, we changed the migration folder structure and made commutative migrations, so you won't face complex conflicts on migrations when working in a team.

What's left here:

• We are finishing handling defaults for Postgres, the last being geometry (yes, we fixed the srid issue here as well).
• We are finishing commutative migrations for all dialects.
• We are finishing up the command, so the migration flow will be as simple as drizzle-kit up for you.

Where it brings us:

• We are getting drizzle-kit into a new good shape where we can call it [email protected]!

Timeline:

• We need ~2 weeks to finish all of the above and send this branch to beta for testing.

Second big branch is a complex one with several HUGE updates

• Bringing Relational Queries v2 finally live. We've done a lot of work here to actually make it faster than RQBv1 and much better from a DX point of view. But in implementing it, we had to make another big rewrite, so we completely rewrote the drizzle-orm type system, which made it much simpler and improved type performance by ~21.4x:

(types instantiations for 3300 lines production drizzle schema + 990 lines relations)

TS v5.8.3: 728.8k -> 34.1k
TS v5.9.2: 553.7k -> 25.4k

You can read more about it here.

What's left here:

• We have 1 issue with TS that is already in progress of being fixed. The issue and Post about fixing.

Where it brings us:

• We are getting drizzle-orm into a new good shape where we can call it [email protected]!

Breaking changes:

• We will have them, but we will have open channels for everyone building on top of drizzle types, so we can guide you through all the changes.

Third branch is adding support for CockroachDB and MSSQL dialects

Support for them is already in the alternation-engine branch and will be available together with the drizzle-kit rewrite.

Summary

All of the work we are doing is crucial and should be done sooner rather than later. We've received a lot of feedback and worked really hard to find the best strategies and decisions for API, DX, architecture, etc., so we can confidently mark it as v1 and be sure we can improve it and remain flexible for all the features you are asking for, while becoming even better for everyone building on top of the drizzle API as well.

We didn't want to stay with some legacy decisions and solutions we had, and instead wanted to shape Drizzle in a way that will be best looking ahead to 2025–2026 trends (v1 will get proper effect support, etc.).

We believe that all of the effort we've put in will boost Drizzle and benefit everyone using it.

Thanks everyone, as we said, we are here to stay for a long time to build a great tool together!

Timelines

We are hoping to get v1 for drizzle in beta this fall and same timeline for latest. Right after that we can go through all of the issues and PRs and resond everyone. v1 for drizzle should close ~70% of all the bug tickets we have, so on beta release we will start marking them as closed!