drizzle-orm icon indicating copy to clipboard operation
drizzle-orm copied to clipboard

[FEATURE]: don't minify or bundle npm packages

Open arjunyel opened this issue 2 years ago • 1 comments

Describe want to want

End user should be responsible for minifying and bundling into one file. I was hoping to use [SQLite] Add boolean mode to integer before its merged via patch-package. Can't because the npm package doesn't resemble the source code.

Thank you friends!

arjunyel avatar Apr 26 '23 19:04 arjunyel

Interesting! I didn't consider this. While I can easily disable the minification, bundling was introduced as a workaround for some circular dependencies I had that were previously resolved by dynamic require() calls which doesn't work with ESM. Also, the bundler I'm using (Rollup) extracts the common code into hashed chunks, so I don't think you'll be able to use patch-package while the bundling is enabled, because the chunk hashes will be different in every version. So honestly I'm not sure how to address this issue easily. I'm willing to disable the bundling, but I'll need to find a way to resolve those circular dependencies. Which might not be an easy job because I personally didn't face any issues with them, it breaks stuff for other people (so a bit hard to reproduce on my side).

I recognize your use case, it's certainly valid (I'm actually using pnpm patch in drizzle-orm), and I'll work on resolving this.

dankochetov avatar Apr 26 '23 23:04 dankochetov

Implemented in drizzle-orm@beta.

dankochetov avatar Nov 08 '23 07:11 dankochetov