drizzle-orm icon indicating copy to clipboard operation
drizzle-orm copied to clipboard

[SQLite] Add boolean mode to integer

Open raducristianpopa opened this issue 1 year ago • 4 comments

Closes #251.

raducristianpopa avatar Apr 08 '23 10:04 raducristianpopa

There are tests for other SQLite dialects that also need to be updated - libSQL, sql.js.

Would you like me to resolve the deprecation warnings for .values() in these tests files as well?

Also, did you run the integration tests? We currently don't run them automatically in the pipeline.

~~Yes, I ran the integration tests. The only ones that I'm having trouble with are the libsql tests. It looks like the requests are made but for some reason they are failing.~~

Edit: Solved the issue. I was specifying the database URL instead of a local file.

All tests are passing:

  ✔ version › shape
  ─

  568 tests passed
➜ integration-tests (rcp/251)                                         83.489s  (rcp/251)

raducristianpopa avatar Apr 09 '23 13:04 raducristianpopa

Would you like me to resolve the deprecation warnings for .values() in these tests files as well?

Yes please!

dankochetov avatar Apr 09 '23 23:04 dankochetov

See my comment above about the code formatting. Also, please resolve the merge conflicts.

Would you like to format the whole repository? Running pnpm dprint fmt did a lot of formatting in the first place (around 100 modified files). I only used it to format drizzle-zod/src/index.ts.

raducristianpopa avatar Apr 20 '23 04:04 raducristianpopa

See my comment above about the code formatting. Also, please resolve the merge conflicts.

Would you like to format the whole repository? Running pnpm dprint fmt did a lot of formatting in the first place (around 100 modified files). I only used it to format drizzle-zod/src/index.ts.

Hmm, that's weird. I think just formatting the files you changed in this PR should be fine for now.

dankochetov avatar Apr 23 '23 13:04 dankochetov

I added the drizzle-zod tests and fixed the failing check https://github.com/drizzle-team/drizzle-orm/pull/725

meech-ward avatar Jun 06 '23 22:06 meech-ward

Closing this in favor of #725

dankochetov avatar Jun 07 '23 17:06 dankochetov