[FEATURE]: Upgrade esbuild in drizzle-kit to support es2023 target
Running npx drizzle-kit generate errors with Invalid target "es2023" in "--target=es2023" in my project. Upgrading esbuild to the latest version solved that issue.
Describe what you want
Upgrading of esbuild to latest version.
also - esbuild < 0.22 has security issues and the ~ symbol disallows us to upgrade it manually in our repo...
reference: https://github.com/evanw/esbuild/issues/3802
We have the same issue, upgrading esbuild to 0.25.1 (latest as of writing) and drizzle-kit to 0.30.5 (latest as of writing) doesn't help. It only works when using target: ES2022
Come on, guys. Upgrade it - the whole TS/JS world has moved on long time ago :-)
We have the same issue, upgrading esbuild to 0.25.1 (latest as of writing) and drizzle-kit to 0.30.5 (latest as of writing) doesn't help. It only works when using target: ES2022
Thanks for sharing! Iβm facing the same issue. You mentioned it only works when using target: ES2022 β how exactly did you set that target? I'm really struggling with this and can't seem to make it work...
Hi @Renato-dev13 , you just need to add target: ES2022 to tsconfig.json, example config:
{
"compilerOptions": {
"target": "ES2022",
"module": "ES2022",
"outDir": "dist",
"moduleResolution": "Node",
"skipLibCheck": true,
"noUnusedLocals": true,
"strict": true,
"esModuleInterop": true,
"resolveJsonModule": true
},
"include": ["src"]
}
Hi, @ahalimkara. Thanks for the quick reply!
+1, just ran into the same issue.
pLeASe FiX tHiS
+1
+1
Same issue.
+1
+1
+1
will be included in the next release
@AndriiSherman Hey thanks a lot for the fix!
I can see that in 0.31.0 the direct dependency on esbuild was bumped via #4416, but we still transitively depend on older esbuild, which causes the issue mentioned above:
also - esbuild < 0.22 has security issues
Which we get dependabot alerts for. I sort of think this must be a separate issue, but since you've worked on this recently, you probably have the best context.
The dependency chain in question is
[email protected] -> @esbuild-kit/[email protected] (deprecated) -> @esbuild-kit/[email protected] -> [email protected]
Also linking #4045 where people discuss the same issue and propose a possible fix
@AndriiSherman Hey thanks a lot for the fix!
I can see that in 0.31.0 the direct dependency on
esbuildwas bumped via #4416, but we still transitively depend on older esbuild, which causes the issue mentioned above:also - esbuild < 0.22 has security issues
Which we get dependabot alerts for. I sort of think this must be a separate issue, but since you've worked on this recently, you probably have the best context.
The dependency chain in question is
[email protected]->@esbuild-kit/[email protected](deprecated) ->@esbuild-kit/[email protected]->[email protected]Also linking #4045 where people discuss the same issue and propose a possible fix
x2
Dependabot cannot update esbuild to a non-vulnerable version The latest possible version that can be installed is 0.18.20 because of the following conflicting dependencies:
[email protected] requires esbuild@~0.18.20 via a transitive dependency on @esbuild-kit/[email protected] [email protected] requires esbuild@^0.25.2 No patched version available for esbuild The earliest fixed version is 0.25.0.
+1
+1 been seeing this for months now
βWARNβ 2 deprecated subdependencies found: @esbuild-kit/[email protected], @esbuild-kit/[email protected]
drizzle-kit 0.31.4
βββ¬ @esbuild-kit/esm-loader 2.6.5
βββ @esbuild-kit/core-utils 3.3.2
This should be closed in favor of #3067 -- esbuilt-kit/esm-loader needs to be replaced entirely with tsx
In Your Project file tsconfig.json 1)
and Target { "compilerOptions": { "target": "es2023" } }
- if you adding remove -D just add it into npm install -D drizzle-kitβ
npm install drizzle-kit β
to me this worked
Hey everyone!
I've created this message to send in a batch to all opened issues we have, just because there are a lot of them and I want to update all of you with our current work, why issues are not responded to, and the amount of work that has been done by our team over ~8 months.
I saw a lot of issues with suggestions on how to fix something while we were not responding β so thanks everyone. Also, thanks to everyone patiently waiting for a response from us and continuing to use Drizzle!
We currently have 4 major branches with a lot of work done. Each branch was handled by different devs and teams to make sure we could make all the changes in parallel.
First branch is drizzle-kit rewrite
All of the work can be found on the alternation-engine branch. Here is a PR with the work done: https://github.com/drizzle-team/drizzle-orm/pull/4439
As you can see, it has 167k added lines of code and 67k removed, which means we've completely rewritten the drizzle-kit alternation engine, the way we handle diffs for each dialect, together with expanding our test suite from 600 tests to ~9k test units for all different types of actions you can do with kit. More importantly, we changed the migration folder structure and made commutative migrations, so you won't face complex conflicts on migrations when working in a team.
What's left here:
- We are finishing handling defaults for Postgres, the last being geometry (yes, we fixed the
sridissue here as well). - We are finishing commutative migrations for all dialects.
- We are finishing up the command, so the migration flow will be as simple as
drizzle-kit upfor you.
Where it brings us:
- We are getting drizzle-kit into a new good shape where we can call it
[email protected]!
Timeline:
- We need ~2 weeks to finish all of the above and send this branch to beta for testing.
Second big branch is a complex one with several HUGE updates
- Bringing Relational Queries v2 finally live. We've done a lot of work here to actually make it faster than RQBv1 and much better from a DX point of view. But in implementing it, we had to make another big rewrite, so we completely rewrote the drizzle-orm type system, which made it much simpler and improved type performance by ~21.4x:
(types instantiations for 3300 lines production drizzle schema + 990 lines relations)
TS v5.8.3: 728.8k -> 34.1k
TS v5.9.2: 553.7k -> 25.4k
You can read more about it here.
What's left here:
- We have 1 issue with TS that is already in progress of being fixed. The issue and Post about fixing.
Where it brings us:
- We are getting drizzle-orm into a new good shape where we can call it
[email protected]!
Breaking changes:
- We will have them, but we will have open channels for everyone building on top of drizzle types, so we can guide you through all the changes.
Third branch is adding support for CockroachDB and MSSQL dialects
Support for them is already in the alternation-engine branch and will be available together with the drizzle-kit rewrite.
Summary
All of the work we are doing is crucial and should be done sooner rather than later. We've received a lot of feedback and worked really hard to find the best strategies and decisions for API, DX, architecture, etc., so we can confidently mark it as v1 and be sure we can improve it and remain flexible for all the features you are asking for, while becoming even better for everyone building on top of the drizzle API as well.
We didn't want to stay with some legacy decisions and solutions we had, and instead wanted to shape Drizzle in a way that will be best looking ahead to 2025β2026 trends (v1 will get proper effect support, etc.).
We believe that all of the effort we've put in will boost Drizzle and benefit everyone using it.
Thanks everyone, as we said, we are here to stay for a long time to build a great tool together!
Timelines
We are hoping to get v1 for drizzle in beta this fall and same timeline for latest. Right after that we can go through all of the issues and PRs and resond everyone. v1 for drizzle should close ~70% of all the bug tickets we have, so on beta release we will start marking them as closed!