drizzle-orm icon indicating copy to clipboard operation
drizzle-orm copied to clipboard

fix: $with for withReplicas

Open malonehedges opened this issue 1 year ago • 5 comments

$with wasn't being copied over and was undefined

resolves #1834

malonehedges avatar Jan 27 '24 17:01 malonehedges

@worm-emoji @AndriiSherman is there any chance to get this merged? This has been broken for us for many months already and we have to re-apply our patch on every update.

hirbod avatar May 27 '24 16:05 hirbod

it's not that big of a deal if it gets merged or not. life is short

worm-emoji avatar May 27 '24 16:05 worm-emoji

Wow, what a totally normal and totally sane response from an OSS maintainer. Definitely not weird at all, like, at all. patch-package to the rescue, I guess.

EDIT: just figured you're not even a maintainer of this package, got confused by your review stamp.

hirbod avatar May 27 '24 16:05 hirbod

yeah, not a contributor. just approved because i liked the pr. and i responded because you tagged me.

but i hope you can use this moment to touch grass and calm down. maybe go on a long walk or spend some time with family.

i've been in your position before: the PR won't make you happy, i promise. i would just try to forget about it and move on.

worm-emoji avatar May 27 '24 17:05 worm-emoji

I am quite calm, thank you very much. You're correct, this PR does not make me happy. However, every patch I am able to remove and do not have to re-apply with every upgrade saves me time. In my opinion, pinging after 5 months is fair enough. Let's end this convo here. Sorry for tagging you wrongfully.

hirbod avatar May 27 '24 18:05 hirbod

@AndriiSherman how can we get this merged?

dakdevs avatar Oct 10 '24 01:10 dakdevs

@AndriiSherman hoping we can get this merged 🙏 we've just set up read replicas and now starting to get this error in prod.

rchasman avatar Oct 10 '24 13:10 rchasman

+1 can we get this merged in please

harrisonlinowes avatar Oct 23 '24 14:10 harrisonlinowes