drizzle-orm icon indicating copy to clipboard operation
drizzle-orm copied to clipboard

[FEATURE]: Allow orderBy for relational queries to contain joined tables

Open Gerschtli opened this issue 2 years ago • 5 comments

Describe what you want

It may be the easiest showing you an example. I want to do this:

db.query.members.findMany({
	where: eq(members.clubId, 'clubId'),
	orderBy: [asc(members.role), asc(users.firstname), asc(users.lastname)],
	with: { user: true },
});

But asc(users.firstname), asc(users.lastname) is not allowed there, therefore I currently need to write:

db
	.select()
	.from(members)
	.innerJoin(users, eq(members.userId, users.id))
	.where(eq(members.clubId, 'clubId'))
	.orderBy(asc(members.role), asc(users.firstname), asc(users.lastname));

Schema definition:

export const users = pgTable('users', {
	id: text('id').primaryKey(),
	firstname: text('firstname').notNull(),
	lastname: text('lastname').notNull(),
});

export const usersRelations = relations(users, ({ many }) => ({
	members: many(members),
}));

export const members = pgTable('members',	{
	id: serial('id').primaryKey(),
	clubId: text('club_id').notNull(),
	userId: text('user_id').notNull().references(() => users.id),
	role: text('role').notNull(),
});

export const membersRelations = relations(members, ({ one }) => ({
	user: one(users, {
		fields: [members.userId],
		references: [users.id],
	}),
}));

Is there any reason, why this is currently not supported? I would love to see this feature in drizzle to use relational queries more often :)

Gerschtli avatar Sep 03 '23 16:09 Gerschtli

Because it is tightly related: I think it would be also very helpful to apply the same to the where clause.

For example allowing something like this (membersRelations.user.firstname is just an idea):

db.query.members.findMany({
	where: and(eq(members.clubId, 'clubId'), eq(membersRelations.user.firstname, 'foo')),
	with: { user: true },
});

Instead of needing to resort to this API:

db
	.select()
	.from(members)
	.innerJoin(users, eq(members.userId, users.id))
	.where(and(eq(members.clubId, 'clubId'), eq(users.firstname, 'foo')));

Gerschtli avatar Sep 09 '23 11:09 Gerschtli

This might be a duplicate of https://github.com/drizzle-team/drizzle-orm/issues/696 but there is not much information. ping @dankochetov

Gerschtli avatar Sep 09 '23 12:09 Gerschtli

any update?

yasseralsaidi avatar Aug 01 '24 12:08 yasseralsaidi

We needed the same thing (just to sort on the presence of the joined row) and used something like this:

db.query.members.findMany({ orderBy: [desc(sql"members_user"."data" IS NULL)], with: { user: true }, });

Beyond that it's a bit difficult to access individual fields as 'data' is an array so they have to be referenced by position, which could change at any time.

rgarand avatar Aug 20 '24 21:08 rgarand

+1 - when using with and multiple nested/foreign key relationship fields on query would be nice to be able to use them to order/sort.

lucashfreitas avatar Apr 27 '25 06:04 lucashfreitas

+1 this is so frustrating. I'd like to use the ORM with its kit, to keep everything simple rather than having to manually create my queries.

suiramdev avatar Jun 18 '25 14:06 suiramdev

2025... 2 years and nothing

gmonte avatar Jun 18 '25 18:06 gmonte

I think this answer can help: https://github.com/drizzle-team/drizzle-orm/issues/2650#issuecomment-2509792075

So end query will looks like:

db.query.members.findMany({
	where: eq(members.clubId, 'clubId'),
	orderBy: [asc(members.role)],
	with: { 
           users: (users, { asc }) => {
             return [asc(users.firstname), asc(users.lastname)];
          } 
        },
});

sambua avatar Aug 13 '25 11:08 sambua

Hey everyone!

I've created this message to send in a batch to all opened issues we have, just because there are a lot of them and I want to update all of you with our current work, why issues are not responded to, and the amount of work that has been done by our team over ~8 months.

I saw a lot of issues with suggestions on how to fix something while we were not responding – so thanks everyone. Also, thanks to everyone patiently waiting for a response from us and continuing to use Drizzle!

We currently have 4 major branches with a lot of work done. Each branch was handled by different devs and teams to make sure we could make all the changes in parallel.


First branch is drizzle-kit rewrite

All of the work can be found on the alternation-engine branch. Here is a PR with the work done: https://github.com/drizzle-team/drizzle-orm/pull/4439

As you can see, it has 167k added lines of code and 67k removed, which means we've completely rewritten the drizzle-kit alternation engine, the way we handle diffs for each dialect, together with expanding our test suite from 600 tests to ~9k test units for all different types of actions you can do with kit. More importantly, we changed the migration folder structure and made commutative migrations, so you won't face complex conflicts on migrations when working in a team.

What's left here:

  • We are finishing handling defaults for Postgres, the last being geometry (yes, we fixed the srid issue here as well).
  • We are finishing commutative migrations for all dialects.
  • We are finishing up the command, so the migration flow will be as simple as drizzle-kit up for you.

Where it brings us:

  • We are getting drizzle-kit into a new good shape where we can call it [email protected]!

Timeline:

  • We need ~2 weeks to finish all of the above and send this branch to beta for testing.

Second big branch is a complex one with several HUGE updates

  • Bringing Relational Queries v2 finally live. We've done a lot of work here to actually make it faster than RQBv1 and much better from a DX point of view. But in implementing it, we had to make another big rewrite, so we completely rewrote the drizzle-orm type system, which made it much simpler and improved type performance by ~21.4x:
(types instantiations for 3300 lines production drizzle schema + 990 lines relations)

TS v5.8.3: 728.8k -> 34.1k
TS v5.9.2: 553.7k -> 25.4k

You can read more about it here.

What's left here:

Where it brings us:

  • We are getting drizzle-orm into a new good shape where we can call it [email protected]!

Breaking changes:

  • We will have them, but we will have open channels for everyone building on top of drizzle types, so we can guide you through all the changes.

Third branch is adding support for CockroachDB and MSSQL dialects

Support for them is already in the alternation-engine branch and will be available together with the drizzle-kit rewrite.

Summary

All of the work we are doing is crucial and should be done sooner rather than later. We've received a lot of feedback and worked really hard to find the best strategies and decisions for API, DX, architecture, etc., so we can confidently mark it as v1 and be sure we can improve it and remain flexible for all the features you are asking for, while becoming even better for everyone building on top of the drizzle API as well.

We didn't want to stay with some legacy decisions and solutions we had, and instead wanted to shape Drizzle in a way that will be best looking ahead to 2025–2026 trends (v1 will get proper effect support, etc.).

We believe that all of the effort we've put in will boost Drizzle and benefit everyone using it.

Thanks everyone, as we said, we are here to stay for a long time to build a great tool together!

Timelines

We are hoping to get v1 for drizzle in beta this fall and same timeline for latest. Right after that we can go through all of the issues and PRs and resond everyone. v1 for drizzle should close ~70% of all the bug tickets we have, so on beta release we will start marking them as closed!

AndriiSherman avatar Aug 30 '25 18:08 AndriiSherman