drizzle-orm
drizzle-orm copied to clipboard
[BUG] MySQL relational query syntax error
What version of drizzle-orm are you using?
0.28.3
What version of drizzle-kit are you using?
0.19.5
Describe the Bug
Using MySQL and the following schema:
export const tickets = mysqlTable(
"tickets",
{
uuid: varchar("uuid", { length: 36 }),
},
(table) => {
return {
uuid: index("uuid").on(table.uuid),
};
},
);
export const ticketsRelations = relations(tickets, ({ many }) => ({
transferData: many(transferData),
}));
export const transferData = mysqlTable(
"transfer_data",
{
id: bigint("id", { mode: "number" }).autoincrement().primaryKey().notNull(),
ticketId: bigint("ticket_id", { mode: "number" }),
data: json("data"),
},
(table) => {
return {
id: unique("id").on(table.id),
ticketId: unique("ticket_id").on(table.ticketId),
};
},
);
export const transferDataRelations = relations(transferData, ({ one }) => ({
ticket: one(tickets, {
fields: [transferData.ticketId],
references: [tickets.id],
}),
}));
and the following query:
db.query.tickets.findMany({
with: {
transferData: true,
},
limit: 10,
});
I get this syntax error:
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '(select coalesce(json_arrayagg(json_array(`tickets_transferData`.`id`, `tickets_' at line 1
Expected behavior
No syntax error
Environment & setup
Google Cloud Platform CloudSQL, MySQL 5.7
please make sure to check the version of your maria db if it is less than 10.5 in my case it can't
Thanks, I was suspecting an incompatible version. I'm using MySQL 5.7 btw. Do you know whether the minimal required versions are documented somewhere?
I'm using the latest version, and everything is working perfectly
We are getting this exact same issue as well using Drizzle-Orm with a MySQL 5.7 database. Does Drizzle require a minimum version for MySQL?
We are getting this exact same issue as well using Drizzle-Orm with a MySQL 5.7 database. Does Drizzle require a minimum version for MySQL?
It seems like yes! Yesterday I tried migrating my database to MySQL 8.0 from MySQL 5.7 and it started working.
It should be mentioned in the documentation 🥲
I have same issue on MariaDB 10.4 and 11.2 (not tested the others)
I have same issue on MariaDB 10.4 and 11.2 (not tested the others)
Same case here (mysql Ver 15.1 Distrib 10.4.32-MariaDB, for Linux (x86_64))
The issue is the use of lateral joins which are not supported by MariaDB at all, MySQL < 8 and PostgreSQL < 9.3. This should be documented somewhere as i was facing the same issue and now have to figure out licensing for MySQL 8 or migrate to PostgreSQL for my project.
There is an open Feature Request for MariaDB since 2019. https://jira.mariadb.org/browse/MDEV-19078
But they don't seem to bother implementing the feature every other database has.
I also have the same issues, i found out that Lateral join not support MySQL < 8 . Since i use with latest version of MySQL works fine, hope it fixed or mentioned in Documentation please.
According to the documentation, using mode: "planetscale" disable usage of lateral joins.
Maybe it's the way to go. If it works, maybe this mode should be renamed and documentation improved to indicates that it is also suitable for mariadb and mysql < 8.0
I have same issue on MariaDB 10.4 and 11.2 (not tested the others)
mariadb 11.4.2 here, and it doesn't work
with using mode: "planetscale" works for me too
Hey everyone!
I've created this message to send in a batch to all opened issues we have, just because there are a lot of them and I want to update all of you with our current work, why issues are not responded to, and the amount of work that has been done by our team over ~8 months.
I saw a lot of issues with suggestions on how to fix something while we were not responding – so thanks everyone. Also, thanks to everyone patiently waiting for a response from us and continuing to use Drizzle!
We currently have 4 major branches with a lot of work done. Each branch was handled by different devs and teams to make sure we could make all the changes in parallel.
First branch is drizzle-kit rewrite
All of the work can be found on the alternation-engine branch. Here is a PR with the work done: https://github.com/drizzle-team/drizzle-orm/pull/4439
As you can see, it has 167k added lines of code and 67k removed, which means we've completely rewritten the drizzle-kit alternation engine, the way we handle diffs for each dialect, together with expanding our test suite from 600 tests to ~9k test units for all different types of actions you can do with kit. More importantly, we changed the migration folder structure and made commutative migrations, so you won't face complex conflicts on migrations when working in a team.
What's left here:
- We are finishing handling defaults for Postgres, the last being geometry (yes, we fixed the
sridissue here as well). - We are finishing commutative migrations for all dialects.
- We are finishing up the command, so the migration flow will be as simple as
drizzle-kit upfor you.
Where it brings us:
- We are getting drizzle-kit into a new good shape where we can call it
[email protected]!
Timeline:
- We need ~2 weeks to finish all of the above and send this branch to beta for testing.
Second big branch is a complex one with several HUGE updates
- Bringing Relational Queries v2 finally live. We've done a lot of work here to actually make it faster than RQBv1 and much better from a DX point of view. But in implementing it, we had to make another big rewrite, so we completely rewrote the drizzle-orm type system, which made it much simpler and improved type performance by ~21.4x:
(types instantiations for 3300 lines production drizzle schema + 990 lines relations)
TS v5.8.3: 728.8k -> 34.1k
TS v5.9.2: 553.7k -> 25.4k
You can read more about it here.
What's left here:
- We have 1 issue with TS that is already in progress of being fixed. The issue and Post about fixing.
Where it brings us:
- We are getting drizzle-orm into a new good shape where we can call it
[email protected]!
Breaking changes:
- We will have them, but we will have open channels for everyone building on top of drizzle types, so we can guide you through all the changes.
Third branch is adding support for CockroachDB and MSSQL dialects
Support for them is already in the alternation-engine branch and will be available together with the drizzle-kit rewrite.
Summary
All of the work we are doing is crucial and should be done sooner rather than later. We've received a lot of feedback and worked really hard to find the best strategies and decisions for API, DX, architecture, etc., so we can confidently mark it as v1 and be sure we can improve it and remain flexible for all the features you are asking for, while becoming even better for everyone building on top of the drizzle API as well.
We didn't want to stay with some legacy decisions and solutions we had, and instead wanted to shape Drizzle in a way that will be best looking ahead to 2025–2026 trends (v1 will get proper effect support, etc.).
We believe that all of the effort we've put in will boost Drizzle and benefit everyone using it.
Thanks everyone, as we said, we are here to stay for a long time to build a great tool together!
Timelines
We are hoping to get v1 for drizzle in beta this fall and same timeline for latest. Right after that we can go through all of the issues and PRs and resond everyone. v1 for drizzle should close ~70% of all the bug tickets we have, so on beta release we will start marking them as closed!