node-XMLHttpRequest icon indicating copy to clipboard operation
node-XMLHttpRequest copied to clipboard

Added setTimeout for XMLHttpRequest

Open killme2008 opened this issue 11 years ago • 4 comments

We have to set request timeout in our production to avoid blocking too many requests.I added a method setTimeout for XMLHttpRequest.I hope it can be merged into master branch,then i don't have to use my own version of node-XMLHttpRequest.Thanks for your great work.

killme2008 avatar Dec 05 '13 13:12 killme2008

We also need the timeout feature, but we need an interface more similar than the W3C standard. Is it possible to change your implementation to comply (at least at interface level) with the standard?

ortegag avatar Apr 04 '14 19:04 ortegag

@ortegag can you give an example of something "more similar than the W3C standard"

pulkitsinghal avatar Aug 21 '14 04:08 pulkitsinghal

I've seen two separate instances of this issue crop up. +1

Stephenitis avatar Aug 22 '14 18:08 Stephenitis

@driverdan Can you let us know what's stopping you from accepting this PR? Any doubts or qualms you have about it?

pulkitsinghal avatar Aug 29 '14 23:08 pulkitsinghal