zamba icon indicating copy to clipboard operation
zamba copied to clipboard
verified publisher icon drivendataorg

`gpus` on ImagePredictConfig doesn't do anything

Open ejm714 opened this issue 9 months ago • 2 comments

We have a gpus parameter in the ImageClassificationPredictConfig but it's never used anywhere https://github.com/drivendataorg/zamba/blob/d4fe633836ede6f72edd9284f3969b70b9d62f83/zamba/images/config.py#L83-L84

pl.Trainer isn't used in predict()

https://github.com/drivendataorg/zamba/blob/d4fe633836ede6f72edd9284f3969b70b9d62f83/zamba/images/manager.py#L82-L88

In training, gpus are configured based on devices and accelerator and then passed to the trainer in train()

https://github.com/drivendataorg/zamba/blob/d4fe633836ede6f72edd9284f3969b70b9d62f83/zamba/images/config.py#L248-L251

https://github.com/drivendataorg/zamba/blob/d4fe633836ede6f72edd9284f3969b70b9d62f83/zamba/images/manager.py#L315-L324

ejm714 avatar Mar 21 '25 02:03 ejm714

does that means that the gpu parameter can be deleted safely?

TheMathix avatar Apr 15 '25 10:04 TheMathix

does that means that the gpu parameter can be deleted safely?

No, we want the user to be able to control whether inference is performed on gpus (and if so, which devices)

ejm714 avatar Apr 16 '25 02:04 ejm714