Jason Woods

Results 73 comments of Jason Woods

I thought I'd help out with some reviewing. Really would love to be able to set levels for all the loggers from a single routine. I'm thinking reloading configuration to...

Have you read through atom/node-runas#5? Might be related.

Thanks for this - it really helped work out why things were failing!

It did happen in class scope - PR has tests for both that reproduce and the fix solve

OK so I have managed to reproduce on my local but only with `--debug`: ``` XXX 9:05:17 XXX$ ./vendor/bin/phpstan analyze Note: Using configuration file XXX/phpstan.neon. 912/912 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% [OK] No...

All instances are of the below pattern where `condition` appears after `accessCheck`. When `accessCheck` appears at the end just before `execute` the errors disappear even when running with `--debug`. ```...

Found the issue. https://github.com/mglaman/phpstan-drupal/blob/1.1.25/src/Type/EntityQuery/EntityQueryDynamicReturnTypeExtension.php#L59-L78 The return of `$defaultReturnType` is problematic - when tracing PHPStan this default return type comes out of a cache of the return type for the method...

OK fully reproduced. Had an issue where I couldn't see why it wasn't failing for class methods and noticed there's different cache key when the code is inside a class...

Worth noting that composer/composer#9619 is still outstanding and is a peculiar complex one - my last proposal was to not just delete the 1 line but every line in that...

@jurre I updated #2998 and took the `setInstall(false)` approach you recommended and got it working so all expected tests pass. There is some discussion to be had though as I...