app icon indicating copy to clipboard operation
app copied to clipboard

Make settings a modal

Open bordumb opened this issue 2 years ago • 6 comments

Problem

Flagging as bug as if a user intends to find settings, it's a bit confusing.

Currently, if we go to the upper-right drop-down and go to "Settings", that disrupts the user's flow:

  • Blue: this is the only item that is related to "Settings". We are requiring users to navigate to an entirely different page in order to switch 1 small setting. That's a lot of work.
  • Red: everything below is more "About" type of content. This makes for a really busy page with content that isn't related to "Settings". It causes users to try and read the entire page to see what other settings there are, only to learn there's just 1 setting.

image

Proposal

1. Consolidate "Settings" to drop-down

https://app.radicle.xyz/ currently does this as follows:

image

I'd recommend copy/pasting that for 2 reasons:

  • It's a big improvement over navigating to an entirely different page
  • Will make it consistent across our different apps

2. Create an "About" page

a. Add a "About" item in the drop-down list b. Move all of the "About" content to its own "About" page

bordumb avatar Dec 01 '22 19:12 bordumb

Definitely see your point — but let me try to clarify the thinking behind it.

There are already 5 additional settings planned: stream rate unit, primary color, custom tokens, font, and developer mode. These will all be added on this page. I'd argue that that's way too many things to put into a small floating drop-down, especially on mobile. Some of these settings may also require explanation beyond their title to make sense, which we wouldn't really have any space for in a drop-down.

Additionally, the theme toggle also isn't just a switch, but has four distinct modes, so wouldn't really fit into a narrow space well.

To the point of the "about"-type content — i think it's a pretty common pattern for things like OSS credits, "about" and "support" to be part of Settings. Both iOS and Android do that, as does e.g. the Discord app, Amazon, Google Maps (somewhat).

That said, once we have a few more real settings i could see us separating that to another "about" page linked from the menu drop-down for sure 👍

efstajas avatar Dec 01 '22 21:12 efstajas

@brandonhaslegs @evvvritt Would appreciate your input here.

efstajas avatar Dec 02 '22 13:12 efstajas

Let’s just put them in a modal instead of a page. Then you aren’t taken out of context.

Or could just take the mobile version of the settings page and put it all inside the dropdown.

I think about information is fine in settings. Or, you could just remove it. I don’t think you need an about page. The landing page is more of an about page anyway.

brandonhaslegs avatar Dec 02 '22 18:12 brandonhaslegs

I like:

  • modal for settings
  • renaming to "Settings" page to "Help/Info", still with the textual info

evvvritt avatar Dec 06 '22 14:12 evvvritt

@brandonhaslegs still think we should do this?

efstajas avatar Oct 19 '23 09:10 efstajas

Yes!

brandonhaslegs avatar Oct 19 '23 14:10 brandonhaslegs