plugin.program.autowidget icon indicating copy to clipboard operation
plugin.program.autowidget copied to clipboard

handle no path for id

Open djay opened this issue 3 years ago • 1 comments

djay avatar Sep 12 '22 10:09 djay

@djay Kind of a weird way to do it, but I was on the move... I pushed a change that lets us not run manage.get_path_by_id twice in the success case. If you think that looks ok, we can merge this one, and I'll push a version bump.

EDIT: Looking a tiny bit closer, in this instance, we call into this bit of code: https://github.com/drinfernoo/plugin.program.autowidget/blob/7245c413cd87f0e6f0fb16c4063b58955248b634/plugin.program.autowidget/resources/lib/manage.py#L221-L230

That doesn't look particularly performance heavy, but it may still be a good idea to try and spare calls to it, since it is reading from disk.

drinfernoo avatar Sep 12 '22 14:09 drinfernoo