SpatialExperiment icon indicating copy to clipboard operation
SpatialExperiment copied to clipboard

Allow additional SpatialImage file extensions

Open andrewGhazi opened this issue 1 year ago • 2 comments
trafficstars

Hi there, just wanted to file an issue on a small roadblock I ran into. The dataset (HEST [1]) I'm working with has some downscaled images with the extension .jpeg which trips the validity check here which only looks for .jpg. It would be convenient to add patterns for jpeg, tiff, PNG, etc. so that users don't need to rename their files. I can submit a PR if that would be helpful.

[1] https://huggingface.co/datasets/MahmoodLab/hest

andrewGhazi avatar Nov 04 '24 18:11 andrewGhazi

Hi @andrewGhazi,

thanks for your issue, I think this would only improve the flexibility of the class, as far as the file type is supported by the spatialImage methods.

So, if you want to write a PR, please provide a small example with working images.

Thanks, Dario

drighelli avatar Nov 05 '24 13:11 drighelli

I submitted a PR here https://github.com/drighelli/SpatialExperiment/pull/160 👍

andrewGhazi avatar Nov 07 '24 22:11 andrewGhazi