SpatialExperiment
SpatialExperiment copied to clipboard
`cbind`: unique/duplicated `colnames`are left asis/made unique; `read10xVisium`: keep barcodes as `colData`; `spatialCoords/<-`: `withDimnames` argument
trafficstars
Addressing #100 ...
cbindassures unique/duplicatedcolnamesare left asis/made unique- in case of duplicates, column names are prefixed with
n_...where
ncorresponds to the number of the object being combined - to retain original barcode identities, these are now kept as
colData
byread10xVisium(previously used as row names and dropped)
... and #103
- added argument
withDimnamestospatialCoordsgetter & setter - discrepancies b/w
colnames(x)andrownames(spatialCoords(x))throw an error,
unlesswithDimnames=FALSEor the latter areNULL
So, can someone accept this if we're okay with the GA (& changes, ofc)?
the GHA fail during the tests:
── Error ('test_SpatialExperiment-spatialCoords.R:27'): spatialCoords<-,matrix ──
Error in `rownames(xyz) <- NULL`: object 'xyz' not found
do you know why?