Results 29 comments of 漂流

> If dial with the feeler is inside the identify protocol, why don't just call dial_identify(..), with error handling. dial feeler success should mark this dial is feeler, but dial...

> dial identify will open identify with all supported protocols inside it, then close feeler, and keep the session connected no, feeler never opened on dial identify https://github.com/nervosnetwork/ckb/blob/b8f655a204de730ec7fbf7c4bd14586ca9edf5dc/network/src/protocols/identify/mod.rs#L483-L486

dial_identify: - A dial identify to B: connected - A‘s identify open all protocols except feeler to B dial_feeler: - A mark feeler - A dial identify to B: connected...

> But dial_inner is before add_feeler. I think a better description here is, "After successfully sending the command, mark the feeler", there is no dial completed at this time

I think there is something wrong with the modification of the iterator. When the user's request value exceeds the default value, it should be forced to change to the upper...

`sync state` only init with local on start, and will update on sync with other node, never with self mined, I think this is the reason. dev node never has...

> one timeout field should be enough The `time_out: bool` field is used to indicate whether the process terminated normally or after a timeout. Returning a `Result` would complicate the...

> you may using iter.map(|res| res?) to adapt an iterator that returns Result into a form Internally, the iterator cannot directly return to the function `error`. If we directly use...

Thank you for your contribution, but unfortunately, this PR will not be merged due to the following reasons: 1. Although lz4's decompression capability is an order of magnitude higher than...