Anthony Clark comments

Results 30 comments of


                                            Anthony Clark

Fixer does not fix TLint warning about global_namespace_import

TLint doesn't fix this linting issue. I looked into it but couldn't find a way to do it reliably. There are too many edge cases having to do with name...

Adding custom Fixers to PHP CS Fixer

Hi @superbiche, thank you for the feedback on these projects 🙌 I think you're right about the core issue here. I'll take a look to see if anyone offered suggestions...

Adding custom Fixers to PHP CS Fixer

Hi @superbiche, I'm not sure changing the namespace will work because I still rely on classes under Pint, which will keep the `App` namespace. I made a quick test branch...

Adding custom Fixers to PHP CS Fixer

Thanks for testing @Joel-Jensen Looks like I'll have to come at it from a different angle.

Autofix only the file in a specific directory

This is currently not possible. One way we could implement this is to allow Duster to accept a `--config` parameter. This way, you could point it to one for lint...

Autofix only the file in a specific directory

@Mte90 An exclude parameter would be a better solution and would be easier to implement in all tools.

Update config files with new changes added to Duster

Looks like this is now at https://github.com/tighten/tighten-coding-standard/blob/main/standards/Tighten/ruleset.xml

Child relationships don't work with a parent collection.

Unfortunately we can't do something similar to what @gcavanunez did in #120 `with` is used in the following way: ```php public function newQueryWithoutScopes() { return $this->newModelQuery() ->with($this->with) ->withCount($this->withCount); } ```...

Allow a model to be both a parent and child

@tobias-grasse If you're able to, tests would be helpful.

Allow a model to be both a parent and child

I ran this update through the test suite of a larger project and didn't run into any issues.