protocol-v2 icon indicating copy to clipboard operation
protocol-v2 copied to clipboard

PlaceAndTakePerpOrder transactions succeed but no trade is actually executed.

Open Gsuz opened this issue 9 months ago • 3 comments

When using placeAndTakePerpOrder I'm seeing that only a very small % of transactions actually result in a sucessfull trade. Transactions are run and they are sucessfully run but it does not result in a trade. I'm not sure why this is. Is this normal and by design? Compared to when I use placeAndMakeOrder they always result in a trade when the transaction succeeds.

I've been comparing the sdk code for these functions an I can see that PlaceAndTakePerpOrder actually passes in null instead of an orderId here -> https://github.com/drift-labs/protocol-v2/blob/6314d47775dc7c126ab9096b750bfc21ec1c80b9/sdk/src/driftClient.ts#L4825C4-L4825C9

Compared to PlaceAndMakePerpOrder which acutally passes in the orderId as you can see here -> https://github.com/drift-labs/protocol-v2/blob/6314d47775dc7c126ab9096b750bfc21ec1c80b9/sdk/src/driftClient.ts#L4897

Is this a bug?

Gsuz avatar May 16 '24 09:05 Gsuz