Dennis Rieks

Results 69 comments of Dennis Rieks

Hi @donat, would it be possible for you to take a look at this MR? Unfortunately, I don't know the process. Could someone else do a review? You seem to...

Hi @donat, is there anything I can do to enable a review from you or could someone else do a review here? Or could you assign this PR to someone...

Thank you very much @ov7a! I will rebase the MR the solve the conflicts

@bamboo I rebased to v9.0.0 but this seems to be wrong, should I rebase to master to prevent conflicts with 9.3 ? is it possible to plan it for 9.2...

Hi @jbartok, I merged the master branch into this MR, is there anything else I can do?

Hi @jbartok, I added new tests..

Thank you very much @jbartok, you are welcome! You removed some asserts in "downloads wrapper via proxy" (WrapperHttpsIntegrationTest), now two of them are useless, the test will also be green...

@jbartok the tests are failing: ``` Condition failed with Exception: result != null | java.lang.IllegalStateException: No build result is available yet. at org.gradle.integtests.fixtures.AbstractIntegrationSpec.getResult(AbstractIntegrationSpec.groovy:427) at org.gradle.integtests.fixtures.AbstractIntegrationSpec.assertHasResult(AbstractIntegrationSpec.groovy:538) at org.gradle.integtests.fixtures.AbstractIntegrationSpec.outputContains(AbstractIntegrationSpec.groovy:665) at org.gradle.integtests.WrapperHttpsIntegrationTest.downloads wrapper...