David Fernández comments

Results 85 comments of


                                            David Fernández

Equal Sign being pushed.

@kokororin could this be related with the new default configurarion for the extension? Would that configuracltion be applied only to new installations or to upgrades too?

PSR2ModifierVisibilityStaticOrder mangles nullable type declarations in function parameters

Ups, this one is good, thank you.

PSR2ModifierVisibilityStaticOrder mangles nullable type declarations in function parameters

Hi! This should be fixed in the latest release, may you confirm? Thanks in advance.

StripNewlineWithinClassBody adds rogue closing curly bracket when a "class" named argument is used in the body of a function

Thank you.

StripNewlineWithinClassBody adds rogue closing curly bracket when a "class" named argument is used in the body of a function

Hi! This should be fixed in the latest release, may you confirm? Thanks in advance.

Formatter removes whitespace after colon when named argument is called "empty"

Hi @metanomial, this should be fixed in the latest release

Invalid indent when exclude AddMissingCurlyBraces

Thanks, I'll take a look.

Invalid indent when exclude AddMissingCurlyBraces

Hi again @BergenSoft There’s no PSR rule that requires the code to be formatted this way. Therefore, enforcing it would introduce a breaking change.

Strange formatting in new line

Yes, unfortunatelly the formatter does not prefectly work when mixing PHP and HTML. It's a known bug hard to fix, I'll try to take a look at it.

Strange formatting in new line

Sorry, I has no chance to look at it.