ror_ecommerce

ror_ecommerce copied to clipboard

Demo Environment Down

2

Hi There, Did not see the issue, but the server at ror-e.herokuapp.com is down and not working.

Parrolabs1

jwjwyoung

jwjwyoung

my mistake, didn't notice that delegate is in use

jwjwyoung

https://github.com/drhenner/ror_ecommerce/blob/3db5a29000ac93d6b896469511004e450d019042/app/models/referral.rb#L10 with current validation code, I can create referrals with same email adrress with lowercase/uppercase as attached.  I believe here should use `validates :email, presence: true, uniqueness: {case_sensitive: false},...

jwjwyoung

As per commit message. To fix issues https://github.com/drhenner/ror_ecommerce/issues/194 https://github.com/drhenner/ror_ecommerce/issues/195

JIAZHEN

As per commit message. To fix issues https://github.com/drhenner/ror_ecommerce/issues/193

JIAZHEN

loop update could be update_all

2

app/controllers/application_controller.rb ``` 129 session_cart.cart_items.each do |item| 130 item.update_attribute(:user_id, user.id ) if item.user_id != user.id 131 end ``` replaced by update_all ``` session_cart.cart_items.where.not(user_id: user.id).update_all(user_id: user.id) ```

lelelelemon

some html label generate code could be changed in products/index.html.erb

4

When rendering the products, link_to, image_tag and some other functions are used to generate corresponding label, however they might be expensive, and the contents generated actually have a lot of...

lelelelemon

count could be size , so that when it's loaded, the size will be faster than count

3

ror_ecommerce/app/views/admin/users/show.html.erb:22: # of Items

lelelelemon