snipe-migrations icon indicating copy to clipboard operation
snipe-migrations copied to clipboard

Add postgres support

Open matijakovacevic opened this issue 6 years ago • 3 comments

is it planned?

matijakovacevic avatar Feb 22 '19 20:02 matijakovacevic

No, I haven't planned it, yet... Do you want to submit a PR to add support for it? I want to add support for sqlite and in-memory sqlite. To do this I'm thinking about splitting out some code and using database drivers to handle the snapshot creation and import stuff. Once that's done adding postgress should be much easier.

drfraker avatar Feb 22 '19 20:02 drfraker

To do this I'm thinking about splitting out some code and using database drivers to handle the snapshot creation and import stuff

Good point and I totally agree. I could make a PR for Postgres. Tag me in this issue once you've completed code rewrite using db drivers. Until then I will try to go through the code to see the details of the package.

P.S. As the package is specific to Laravel and still fresh, a proposition about package naming convention.

Something along the line *drfraker/laravel-*nameofpackage, to imply an extension upon the framework and not a general package.

matijakovacevic avatar Feb 22 '19 22:02 matijakovacevic

Does the latest pull request help solve this issue? PR 29

drfraker avatar Sep 25 '19 23:09 drfraker