scrivener_ecto icon indicating copy to clipboard operation
scrivener_ecto copied to clipboard

Fix aggregate for combination queries

Open iguberman opened this issue 3 years ago • 2 comments

Fixes https://github.com/drewolson/scrivener_ecto/issues/99)

iguberman avatar Dec 08 '21 06:12 iguberman

@iguberman thanks for the PR! I've noticed you've been incrementally adding some commits. Is this ready for review / merge or are you still working on it?

drewolson avatar Dec 30 '21 16:12 drewolson

==> scrivener_ecto
Compiling 2 files (.ex)
warning: variable "caller" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/scrivener/paginater/ecto/query.ex:48: Scrivener.Paginater.Ecto.Query.total_entries/4

warning: variable "count_query" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/scrivener/paginater/ecto/query.ex:57: Scrivener.Paginater.Ecto.Query.total_entries/4

warning: variable "prefix" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/scrivener/paginater/ecto/query.ex:49: Scrivener.Paginater.Ecto.Query.total_entries/4

warning: variable "expr" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/scrivener/paginater/ecto/query.ex:89: Scrivener.Paginater.Ecto.Query.aggregate/1

please fix the warnings.

Also run: mix format

kelostrada avatar Feb 10 '22 15:02 kelostrada