metadata-extractor icon indicating copy to clipboard operation
metadata-extractor copied to clipboard

Published 20 hours ago • verified publisher icon drewnoakes

Detect incorrect makernote offsets

Open jnioche opened this issue 5 years ago • 6 comments

[FEATURE REQUEST]

Copied from https://stackoverflow.com/q/56445656/432844

EXIFTool can detect when the offset of tags is incorrect

[ExifTool] Warning : [minor] Possibly incorrect maker notes offsets (fix by 1060?)

Can we detect incorrect offsets with metadata-extractor and ideally fix them in the same way?

jnioche avatar Jun 05 '19 08:06 jnioche

Can you provide an image with such incorrect offsets? Without one it's impossible to verify a fix.

drewnoakes avatar Jun 05 '19 09:06 drewnoakes

panasonic sony

There are two images attached that give the warning. When you use the -F switch in exiftool the offsets are fixed and some more fields are then visible (inc internal serial number).

jnioche avatar Jun 05 '19 13:06 jnioche

@jnioche thank you for the images. I don't know when I or anyone else will get to look at this, but at least whoever does has all the info they need. If you want to try and fix this yourself I'd be happy to review a pull request.

drewnoakes avatar Jun 06 '19 00:06 drewnoakes

The corresponding code in EXIFtool is https://github.com/exiftool/exiftool/blob/master/lib/Image/ExifTool/MakerNotes.pm#L1305

jniocheCF avatar Jul 15 '19 13:07 jniocheCF

@jniocheCF have you looked at whether that technique could be applied to this project?

drewnoakes avatar Jul 15 '19 23:07 drewnoakes

@drewnoakes not yet, the comment above was a note to myself

jnioche avatar Jul 16 '19 09:07 jnioche