Best way to add new Makernotes?

[XPav]

I've got some imagery from a PhaseOne camera.

Exiftool has it documented here: https://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/PhaseOne.html

I see how to create the Directory and Descriptors for a MakerNote. Assuming a relatively conventional Makernote, is this created from ExifTiffHandler ::ProcessMakernote?

[markegorman]

How do I open and look at

Get Outlook for iOShttps://aka.ms/o0ukef

---

From: Alex Pavloff [email protected] Sent: Tuesday, January 22, 2019 9:29 AM To: drewnoakes/metadata-extractor-dotnet Cc: Subscribed Subject: [drewnoakes/metadata-extractor-dotnet] Best way to add new Makernotes? (#153)

I've got some imagery from a PhaseOne camera.

Exiftool has it documented here: https://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/PhaseOne.htmlhttps://eur01.safelinks.protection.outlook.com/?url=https:%2F%2Fwww.sno.phy.queensu.ca%2F~phil%2Fexiftool%2FTagNames%2FPhaseOne.html&data=02%7C01%7C%7C40c304245a9c4168319108d68086d25f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636837713871230620&sdata=u6mkZe2JZgIwgknzEW9F6uYW8o2IaX%2FgJSEQeCqXRk4%3D&reserved=0

I see how to create the Directory and Descriptors for a MakerNote. Assuming a relatively conventional Makernote, is this created from ExifTiffHandler ::ProcessMakernote?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdrewnoakes%2Fmetadata-extractor-dotnet%2Fissues%2F153&data=02%7C01%7C%7C40c304245a9c4168319108d68086d25f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636837713871230620&sdata=zhzi2OPwA6%2Bd3qddXDi7nuAiDyUbEvm%2BtoBzDv5Tz68%3D&reserved=0, or mute the threadhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAqp-iDwZmAmdFcPzfQMqUVOEkiKkuGcSks5vFzx4gaJpZM4aNCwD&data=02%7C01%7C%7C40c304245a9c4168319108d68086d25f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636837713871230620&sdata=Tp2TKW9lVtN2szp6sNViJr3Qj%2FD%2BOXWi9qhsQb%2FY0N4%3D&reserved=0.

[kwhopper]

If the makernote is stored as part of a standard TIFF-formatted file, then that's the correct class. I assume it would go through the exif classes but haven't looked into PhaseOne parsing.

[markegorman]

Ok thanks I see what I can do Thanks

Get Outlook for iOShttps://aka.ms/o0ukef

---

From: kwhopper [email protected] Sent: Tuesday, January 22, 2019 10:09 AM To: drewnoakes/metadata-extractor-dotnet Cc: markegorman; Comment Subject: Re: [drewnoakes/metadata-extractor-dotnet] Best way to add new Makernotes? (#153)

If the makernote is stored as part of a standard TIFF-formatted file, then that's the correct class. I assume it would go through the exif classes but haven't looked into PhaseOne parsing.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdrewnoakes%2Fmetadata-extractor-dotnet%2Fissues%2F153%23issuecomment-456481124&data=02%7C01%7C%7C9bf00178db4a4faa3f4208d6808c6ee2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636837737969632317&sdata=KRTGP3fl2FQVaOTs634QGBBuG90vExCs3vJOA0JwmFs%3D&reserved=0, or mute the threadhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAqp-iJYnRIrs53h2hI7TMSHSUEIhbWBgks5vF0XjgaJpZM4aNCwD&data=02%7C01%7C%7C9bf00178db4a4faa3f4208d6808c6ee2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636837737969632317&sdata=x46nN9kx4vsz48YmAW852VIRvTSTyUaEXuNNUz2q0EM%3D&reserved=0.

[drewnoakes]

@XPav as @kwhopper says, most makernotes are TIFF data. You'll need to create a new directory class and descriptor class, then wire it up in ProcessMakerNote with some heuristic (usually based on make/model). There are plenty of examples in the current code. Feel free to submit a PR.