mailchimp-api icon indicating copy to clipboard operation
mailchimp-api copied to clipboard

Allow passing an array to the constructor so we can configure the timeout

Open driade opened this issue 5 years ago • 3 comments

driade avatar Jul 01 '19 15:07 driade

Thinking about this further, if we're adding $parameters to the contractor, would it not make more sense to add $parameters to the method calls too? Rather than just $timeout?

drewm avatar Jul 04 '19 09:07 drewm

It totally makes sense but, then, isn't it breaking change? I wasn't sure if you think that's ok.

In my opinion I'd in fact remove that option from the method calls, and let the user the option to "configure" all the possible parameters (ssl, timeout) via the constructor / an additional settter.

driade avatar Jul 04 '19 11:07 driade

Let's see if it's finally accepted! I'd update the documentation if it's.

driade avatar Oct 01 '20 15:10 driade